3.5.6 'make check' problems... LOTS of them

[Matthew Woehlke]

David Faure wrote:
> On Friday 02 February 2007, Matthew Woehlke wrote:
>> Matthew Woehlke wrote:
>>> Next: kio/tests does REALLY badly on the mimetype test. First /root 
>>> failed (because my /root is 750 and I am running as a user that gets to 
>>> use the group permissions). Fixed by chmod 700'ing /root, but this 
>>> indicates that the test assumptions are flawed. Then trash:/ gave the 
>>> icon '(null)'. Not sure why on this one
> 
> Because kio_trash isn't installed. So the proper fix would be to do
>   if ( KProtocolInfo::isKnownProtocol( "trash" ) ) {
>      ...
>   }
> 
> Please use ktempdir instead of a hardcoded /tmp location and atexit.

How about this attempt? It's closer, but the directory isn't deleted for 
some reason (tested as non-root, so I can say that it works, at least, 
although I don't have an easy way to not have the trash kioslave).

-- 
Matthew
OFFICER throws a tear gas grenade at you. You start to feel nauseous. 
You need fresh air quickly.
 > OPEN WINDOWS
Sorry, I have a philosophical objection to Microsoft products.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mimetest.patch
Type: text/x-patch
Size: 1420 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070202/21415b9b/attachment.bin>