Making KCoreConfigSkeleton::useDefaults() virtual

Allen Winter winter at kde.org
Mon Dec 31 17:00:38 GMT 2007


On Monday 31 December 2007 11:50:07 Andreas Pakulat wrote:
> Hi,
> 
> I know 4 days to the release tagging, BiC changes have long been done
> with and stuff. 
> 
> Unfortunately I just now looked again deeper into KDevelop's project
> configuration stuff due to a bug in the cmake plugins usage of it.
> 
> What I found is that KCoreConfigSkeleton::useDefaults advertises itself
> as being overrideable and should be overridden in subclasses if special
> cases are needed an usrUseDefaults is not enough. This is the case for
> KDevelop. 
> 
> Thus I'd like to make that function virtual ASAP. Its SC and no
> lxr.kde.org didn't find any code that subclasses and overrides
> useDefaults currently so no code is affected by that change.
> 
> How are my chances?
> 
Seems harmless enough to me.
So I'm ok with it.





More information about the kde-core-devel mailing list