[PATCH] Nicer category headers in SystemSettings
Aurélien Gâteau
aurelien.gateau at free.fr
Mon Dec 31 10:15:09 GMT 2007
Rafael Fernández López wrote:
> Hi Aurélien and all,
>
> I've always preferred a 1 pixel line, but some people told me it was
> almost missing.
1 pixel border lines are really common on the web and in other application.
It's only a decoration, so I don't think it's that much of a problem if
some people can't see it. As long as they can see the category text.
> Well, I really vote for this change, but not exactly
> for your patch.
>
> The reasons of why I don't actually support this patch 100% is:
>
> - Only systemsettings => kpluginselector and dolphin would look different
Yes, that's true. It would need to be patched too.
> - Margin of the title removed. I really think having a small margin
> difference between the line start and the text is better.
That's highly subjective. The margin on the left of the title looks like a
bug to me.
>
> Patches are for SystemSettings, Dolphin and KPluginSelector:
> http://media.ereslibre.es/2007/12/kdelibs-kpluginselector.diff
> http://media.ereslibre.es/2007/12/kdebase-categorized.diff
>
> I really think they look better this way. I also have added a needed
> parameter to the method that determines the category height when
> drawing (the index).
>
> Aurélien, if this patches are accepted, and you want to commit it just
> tell it here and CCMAIL me the commit :)
Ok.
Aurélien
More information about the kde-core-devel
mailing list