[PATCH] Fix installation of kdebase for source/build path or $KDEDIR containing spaces

Thiago Macieira thiago at kde.org
Sun Dec 30 22:55:56 GMT 2007


Ingo Klöcker wrote:
>Hi,
>
>if the source/build path or $KDEDIR contain spaces then during
>installation of kdebase/workspace a few post-install commands fail
>because the spaces are not properly escaped.
>
>The attached patch should fix all those problems. It
>- properly escapes the path of kcheckpass when chowning/chmoding it,
>- properly escapes the path of mkpamserv when calling it,
>- properly escapes the path and arguments of genkdmconf when calling it.
>
>The patch is more or less straightforward, but given that I have
>basically no knowledge about cmake magic I thought I'd ask for a review
>before committing.
>
>
>Regards,
>Ingo

Does CMake have a backslash-escaping function we can use?

Otherwise, the patch will work for spaces, but not some other "weird" 
caracters, including quotes and apostrophes.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071230/10c40c23/attachment.sig>


More information about the kde-core-devel mailing list