KPropertiesDialog needs a fix

[Tobias Koenig]

On Mon, Dec 24, 2007 at 08:30:33PM +0100, Rafael Fernández López wrote:
> Hi again,
Hej,

sorry for the late reply, didn't followed the thread first...

I don't like that patch at all, as it breaks the design of the PageView
completely and moves that class into the direction of KJanusWidget, a
class with a lot of 'if case X do this, otherwise do that' where nobody
was able to maintain that class anylonger... don't let's do the same
mistake!!!

> +  if (faceType == KPageView::Tabbed) {
> +    stack->setVisible(false);
> +    layout->removeWidget( stack );
> +  } else {
> +    layout->addWidget( stack, 2, 1 );
> +    stack->setVisible(true);
> +  }
...

> +  if (faceType != KPageView::Tabbed) {
>    QWidget *widget = qvariant_cast<QWidget*>( model->data( index, KPageModel::WidgetRole ) );
>    if ( widget ) {
>      if ( stack->indexOf( widget ) == -1 ) { // not included yet
> @@ -214,6 +228,7 @@ void KPageViewPrivate::_k_pageSelected(c
>    }
>  
>    updateTitleWidget(index);
> +  }
...

Ciao,
Tobias
-- 
Separate politics from religion and economy!
The Council of the European Union is an undemocratic and illegal institution!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071227/2c02cb3c/attachment.sig>