KPropertiesDialog needs a fix

Rafael Fernández López ereslibre at
Mon Dec 24 17:33:32 GMT 2007


I am replying to this mail, but I've also seen the BC one...

I have been working offline these days because I'm on my vacation home and 
haven't got Internet there... well, I have the fix prepared.

The changes on the patch are completely BC and they would be nice to get in. 
It fixes all applications that rely on this code.

It also fixes minor stuff like if you had a page selected and you change the 
face it was lost (because of the selectionmodel being set the first row in as 
currentindex in all cases).

Please, I need a fast reply if I can commit this. Let's say before Friday 28. 
If this patch is approved and I haven't committed on 29 (I will CCMAIL the 
commit to this mailing list), please someone commit it.

I consider this issue an important one for consistency.

The fix is not on KPropertiesDialog itself but in the code of the libraries, 
so please I'd ask that if you committed this, to revert since the fix is 
here, and it fixes a more general use case. Instead of using a QTabBar for 
this it uses a QTabWidget.

Bye and thanks, 
Rafael Fernández López

GPG Fingerprint: B9F4 4730 43F8 FFDD CC5E BA8E 724E 406E 3F01 D070
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs.diff
Type: text/x-diff
Size: 7486 bytes
Desc: not available
URL: <>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list