KPropertiesDialog needs a fix

[Aurélien Gâteau]

David Faure wrote:

> On Monday 24 December 2007, Andreas Pakulat wrote:
>> On 24.12.07 01:09:58, Aurélien Gâteau wrote:
>> > Attached patch does this: it makes KPropertiesDialog inherits from
>> > KDialog instead of KPageDialog and set a QTabWidget as the main widget.
>> > What do you think about this?
>> 
>> Isn't this a BIC change and thus not possible anymore until KDE5?
> 
> Hmm really? There have been some BIC changes not so long ago, IIRC...
> 
So do you think it can go in?
Anyway, I made another version which should be BC (correct me if I am
wrong), it's just quite ugly. It keeps KPropertiesDialog inheriting from
KPageDialog, but use KPageDialog::Plain face type and adds the QTabWidget
as the only page. It probably needs to make other page adding methods from
KPageDialog private.

Aurélien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kio_kpropertiesdialog_qtabwidget_bc.diff
Type: text/x-diff
Size: 2265 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071224/1934e072/attachment.diff>