[PATCH] Merging the web/document Go menus

David Faure faure at kde.org
Fri Dec 21 14:33:42 GMT 2007

Ever since ui_standards.rc was created from the KDE2 HIG, it has featured
a separate "Go" menu called go_web and a "Go" menu called go_document.
From a HIG point of view it makes sense, apps have either one or the other,
and the set of actions in those two alternatives is different
go_web: up, back, forward, home, <app-dependent>
go_document: previous, next, goto page, goto line, first, last, <app-dependent>.

However when embedding okular into konqueror (viewing a PDF embedded),
you end up with two menus with the text "Go" :-)

Pino and I looked at multiple ways of fixing that, but the cleanest way is to
just get rid of the separation in ui_standards.rc. The HIG is still right when it says
that apps use either one set of actions or the other, but when combing apps
(okular+konqueror) we do need all that to come from a single menu.

Can I commit the attached patch on Monday?
I tested that it doesn't lead to stupidly-placed separators in e.g. standard okular;
and the merging now works. I'll move all the filemanagement-related actions
from konqueror to dolphinpart, to make this Go menu less huge.

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: modified_rcfiles.diff
Type: text/x-diff
Size: 9116 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071221/097695bc/attachment.diff>

More information about the kde-core-devel mailing list