[PATCH] KProcess port of khelpcenter
Ralf Habacker
ralf.habacker at freenet.de
Thu Dec 20 17:59:37 GMT 2007
Oswald Buddenhagen schrieb:
> On Thu, Dec 20, 2007 at 04:47:29PM +0100, Ralf Habacker wrote:
>
>> Index: scrollkeepertreebuilder.cpp
>> ===================================================================
>> --- scrollkeepertreebuilder.cpp (revision 749421)
>> +++ scrollkeepertreebuilder.cpp (working copy)
>> + KProcess proc;
>> proc << "scrollkeeper-get-content-list";
>> proc << lang;
>> +
>>
> this code is missing the appropriate setOutputChannelMode().
>
you probably mean setProcessChannelMode() as listed in
http://doc.trolltech.com/4.3/qprocess.html#setProcessChannelMode
> now that i think of it, i probably missed this in all the other patches
> ...
>
no problem here :-) QProcess::SeparateChannels is the default
>> + proc.start();
>> + if ( !proc.waitForFinished() ) {
>> kDebug(1400) << "Could not execute scrollkeeper-get-content-list";
>> return 0;
>> }
>> + mContentsList = proc.readAllStandardOutput();
>>
>>
> unlike the kprocio code, this won't strip the trailing newline. use
> trimmed().
>
>
fixed and commited.
Ralf
More information about the kde-core-devel
mailing list