[PATCH] KProcess port of khelpcenter

Oswald Buddenhagen ossi at kde.org
Thu Dec 20 15:55:37 GMT 2007


On Thu, Dec 20, 2007 at 04:47:29PM +0100, Ralf Habacker wrote:
> Index: scrollkeepertreebuilder.cpp
> ===================================================================
> --- scrollkeepertreebuilder.cpp	(revision 749421)
> +++ scrollkeepertreebuilder.cpp	(working copy)
> +  KProcess proc;
>    proc << "scrollkeeper-get-content-list";
>    proc << lang;
> +  
this code is missing the appropriate setOutputChannelMode().
now that i think of it, i probably missed this in all the other patches
...

> +  proc.start();
> +  if ( !proc.waitForFinished() ) {
>      kDebug(1400) << "Could not execute scrollkeeper-get-content-list";
>      return 0;
>    }
> +  mContentsList = proc.readAllStandardOutput();
> 
unlike the kprocio code, this won't strip the trailing newline. use
trimmed().

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.




More information about the kde-core-devel mailing list