[PATCH] KProcess port of khelpcenter

Oswald Buddenhagen ossi at kde.org
Thu Dec 20 15:47:31 GMT 2007


On Thu, Dec 20, 2007 at 04:39:51PM +0100, Ralf Habacker wrote:
> +    KProcess *proc = new KProcess();
> +	*proc << KShell::splitArgs(commonSearchProgram);
>  
tab alert! :)

> -    mSearchResult = mSearchResult.replace(QLatin1String("http://localhost/"), QLatin1String("file:/"));
> +    mSearchResult = mSearchResult.replace("http://localhost/", "file:/");
>
fwiw, the assingment is not necessary, as replace() modifies the original
string.
to be pedandic, the replacement string should be file:/// (at least some
say so ... i find it stupid myself).

>      mSearchResult = mSearchResult.mid( mSearchResult.indexOf( '<' ) );
>  
one might want to change that to remove()ing the leading chars instead.
then the assignment goes away as well. :)

rest seems fine.

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.




More information about the kde-core-devel mailing list