[PATCH] Scrollable page dialogs

Aurélien Gâteau aurelien.gateau at free.fr
Wed Dec 19 14:55:37 GMT 2007


While working on SystemSettings module size problems, I thought it would be
nicer to prevent the bottom button bar from scrolling. Digging in the code
I realized I needed to patch KPageView, so it would impact all KDE dialogs.

Attached are two patches, the kdeui one which adds scrollbars to KPageView
if necessary, the other one removes QScrollArea from SystemSettings, as
it's no longer needed.

Here are a series of screenshots showing the difference. All shots were made
using the default SystemSettings size.

- Network / Proxy
Before: http://img178.imageshack.us/img178/2037/beforenetworkproxyty8.png
After: http://img178.imageshack.us/img178/950/afternetworkproxyhg5.png

- Accessibility
Before: http://img208.imageshack.us/img208/4717/beforea11ykq2.png
After: http://img208.imageshack.us/img208/8915/aftera11ykz2.png

As I said, this patch impacts all KDE KPageDialog instances. For example,
the Konqueror settings dialog does not resize itself anymore[1] when
switching between pages. Here is a screenshot:


Do you think this should go in? Or should I try to work on a patch which
would only affect SystemSettings?


[1]: It still resizes a bit when there is not enough room for the page
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scrollable_pageviews_kdeui.diff
Type: text/x-diff
Size: 1666 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071219/f30038a7/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: scrollable_pageviews_systemsettings.diff
Type: text/x-diff
Size: 2179 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071219/f30038a7/attachment-0001.diff>

More information about the kde-core-devel mailing list