[PATCH] kdebase/systemsettings: apply changes

Allen Winter winter at kde.org
Sat Dec 8 18:27:01 GMT 2007

On Tuesday 27 November 2007 01:19:03 Aaron J. Seigo wrote:
> On Monday 26 November 2007, xing rick wrote:
> > The attached patch can fix the problem.
> > It will modify files in /kdebase/workspace/systemsettings/. Is it OK for
> > commit?
> looks ok .. unfortunate to have to call this from mainwindow as it sort of 
> breaks the encapsulation a bit,
> i wonder why "emit finished()" is in KDialog::hideEvent rather that in 
> KDialog::closeEvent ... that would probably also fix this issue. *shrug*

Rick Xing told me he doesn't have an svn account.

I can't tell from Aaron's comment above if he wants to emit finished in
KDialog::closeEvent().  Or if I should commit Rick's patch for him.

How to proceed?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071208/e86614e6/attachment.htm>

More information about the kde-core-devel mailing list