[patch] cosmetic fix for KPlotWidget

Hans Meine hans_meine at gmx.net
Mon Dec 3 14:31:23 GMT 2007


Am Montag, 03. Dezember 2007 14:58:37 schrieb Jason Harris:
> On 12/2/07, Hans Meine <hans_meine at gmx.net> wrote:
> > Argh!  This patch is *wrong*, the original was right.  What happens with
> > *this* patch is that you effectively shift only the plot axes/grid, but
> > not the data.  Thus, the data will not be put at the right positions
> > anymore.
>
> Heh, I didn't expect all this controversy.  Well, I have applied the
> first patch; the second I proposed but did not apply.  So I can just
> leave things as they stand now.

And after my last mail, I thought one could as well disable AA for drawing the 
grid, but the first patch would have been necessary then, too.  And if 
someone still wants to apply something like the second patch, he/she should 
make sure that the grid is not shifted to the right/bottom; I suspect that 
the half-integer coordinates could be exactly the problematic border case, 
i.e. they would be undesirably shifted by 1 pixel in each X/Y direction, 
which would have to be corrected by *not* shifting by (0.5,0.5) only when 
drawing with AA.(*)

Ciao, /  /
     /--/
    /  / ANS

*: Yes, this is another example where we need to think about things only 
because the AA/traditional painting use different coordinate systems.




More information about the kde-core-devel mailing list