[PATCH]: deleteGroup deletes sub groups too

Aaron J. Seigo aseigo at kde.org
Sun Dec 2 00:52:08 GMT 2007


On Saturday 01 December 2007, Oswald Buddenhagen wrote:
> On Sat, Dec 01, 2007 at 04:58:33PM -0700, Aaron J. Seigo wrote:
> > here is a patch to fix deleteGroup such that it deletes not only the keys
> > in that group but also all subgroups.
> >
> >
> > --- tests/kconfigtest.cpp	(revision 743218)
> > +++ tests/kconfigtest.cpp	(working copy)
> > @@ -114,6 +114,16 @@
> > +  KConfigGroup ct = cg;
> > +  cg = KConfigGroup(&ct, "Nested Group 1");
> > +  [...]
>
> this looks ... weird.

yeah, i didn't both making it pretty because it's "just" test code. i needed 
to keep all the various groups around to do the nesting and this was a fast 
way to do it.

> > --- config/kconfig.cpp	(revision 743218)
> > +++ config/kconfig.cpp	(working copy)
>
> this is *so* inefficient - the internal api just sucks. whatever.

yeah, i know =/

> you might want to update the TODO file.

will do.


-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071201/2ee37642/attachment.sig>


More information about the kde-core-devel mailing list