[PATCH] phonon-xine VideoWidgetXT

[Lúcio Corrêa]

Hi guys.

I found a small bug while compiling phonon-xine:

If the build system doesn't find libxine >= 1.1.5 and libxcb dev
files, it defines PHONON_XINE_NO_VIDEOWIDGET, right?

And in the code we have:

#ifndef PHONON_XINE_NO_VIDEOWIDGET
        xcb_visual_t m_visual;
        xcb_connection_t *m_xcbConnection;

But in VideoWidgetXT it tries to initialize m_xcbConnection even if
PHONON_XINE_NO_VIDEOWIDGET is defined:

VideoWidgetXT::VideoWidgetXT(QWidget *w)
    : m_xcbConnection(0),

So, it doesn't compile, getting this error:

/home/kde-devel/kde/src/KDE/kdemultimedia/phonon-xine/videowidget.cpp:
In constructor 'Phonon::Xine::VideoWidgetXT::VideoWidgetXT(QWidget*)':
/home/kde-devel/kde/src/KDE/kdemultimedia/phonon-xine/videowidget.cpp:88:
error: class 'Phonon::Xine::VideoWidgetXT' does not have any field
named 'm_xcbConnection'

Installing libxcb dev files fixed that, of course.

So, i think  m_xcbConnection can't be initialized there, right?
Attached is a patch to fix this.

Best Regards,

-- 
-----------------------------------------------------------------
"Your mind is like a parachute: it works better when open."
Lúcio Flávio Corrêa
(+55) (81) 8897-0537
lucio.correa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: videowidgetpatch.diff
Type: text/x-patch
Size: 380 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070810/818bceda/attachment.bin>