[PATCH] Extend KDateTime with a fancyString()

[David Jarvie]

On Friday 06 April 2007 23:41:44 Tom Albers wrote:
> Hi David,
>
> Op vr 6 apr 2007 13:42 schreef u:
> > On Thursday 05 April 2007 20:44:28 David Jarvie wrote:
> > > On Thursday 5 April 2007 17:58, Tom Albers wrote:
> > > > I extracted the fancy date handling from kmime's date formatter and
> > > > added it to
> > > > KDateTime. I think it belongs to this class and not to kmime.
> > > >
> > > > I would appreciate if someone looked if it's ok, so I can commit.
> > >
> > > IMHO the function doesn't belong in KDateTime in its current form,
> > > since it's basically processes QDateTime values without proper regard
> > > for time zones/UTC offsets.
>
> I really don't have a clue about handling those things. The / my problem
> lies in the fact that I'm getting a KDateTime from kmime and I need to go
> to the fancy date from there. The dateformatter in KMime does not accept
> the KDateTime, so I'm converting it now all over the place, just to get the
> fancy date.
>
> As that routine is pretty time critical (although the model/view setup
> makes it a bit less critical for me). I wanted to prevent those conversions
> and add it to KDateTime. I only extracted the code from dateFormatter, so I
> can not comment on the errors in the code.

> Do you want to take care of it or do you prefer me to look at it later on?
> I don't feel really comfortable in the code, but I can spend more time on
> it if you don't want to.

Okay, I'll add some new conversion stuff to KDateTime::toString() - sometime 
this weekend. It won't need an API change, so there won't be a BIC Mondays 
constraint.

-- 
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/kalarm