kdemultimedia3 - patch to fix lockup of audiocd:/ kioslave
Tilman Vogel
tilman.vogel at web.de
Tue Sep 26 08:27:44 BST 2006
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Stephan Kulow schrieb:
> Am Montag, 25. September 2006 12:18 schrieb Tilman Vogel:
>> Maybe one should just use my fall-back in both cases (linux and non-linux)?
> It would not compile
True, just looked at
<http://cvsup.pt.freebsd.org/cgi-bin/cvsweb/cvsweb.cgi/ports/audio/cdparanoia/files/patch-interface-cdda_interface.h?rev=1.2&content-type=text/x-cvsweb-markup>
Anyway, one could maybe rather make defined(__FreeBSD__) the special
case, not Linux, because the "standard" cdparanoia interface (from
vorbis) has both fields, only in the FreeBSD version, the
ioctl_device_name is stripped off by the ports patch. Don't know what
they gain from it, but ok. This way it was easier to see which exception
(FreeBSD) needs the changed code...
Also, I tried to find out when cdda_device_name is set and when
ioctl_device_name, but the paranoia code is a bit hard to read in this
respect, and if things just work, I'd settle with that...
Tilman
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFFGNZv9ZPu6Yae8lkRAiMjAJ9PjYc13WnWGC7yLtbu/UPbZTU8qgCeNhpk
QJezoVZB3ZOOmXZa2g2VLdI=
=Wm3m
-----END PGP SIGNATURE-----
More information about the kde-core-devel
mailing list