Adding ThreadWeaver libraries to kdelibs
hausmann at kde.org
Wed Sep 6 19:36:39 BST 2006
On Wednesday 6. September 2006 19:50, André Wöbbeking wrote:
> On Wednesday 06 September 2006 19:01, Simon Hausmann wrote:
> > Looks great! A few minor API suggestions though:
> > JobCollection::jobListLength() -> jobCount(). Count is the common
> > term used in Qt for numbering independent objects in a container. It
> > also goes nicely with jobAt(i). Length on the other hand is used for
> > things like QLineF::length.
> I wonder why addJob(), jobAt() and jobListLength() contains job at all?
> It's a JobCollection so it's all about jobs. And jobListLength() could
> be renamed to count() (Qt way) or size() (STL way).
Right. Somehow I was thinking that these functions were in Weaver while I
wrote where they were actually in, as you pointed out. I agree and suggest
the removal of the job suffix then, too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the kde-core-devel