RFC: KToolBox

[Aaron J. Seigo]

On Saturday 02 September 2006 15:06, Matt Broadstone wrote:
> Right - would probably help if I actually attached the class :)

;)

the first ctor should be marked explicit KToolBox(QWidget *parent = 0);

the font size is hardcoded to 8.0 pts in KToolBoxTab ... that's an a11y 
problem and will probably look poor on some systems in general ... would 
probably be better to look for the largest size of the font that fits?

the code also bears a striking resemblance to the code in qtoolbox. in fact, 
it sort of looks like a lot of it was copy 'n pasted. if so then there's a 
licensing problem with that code in that your class is LGPL'd but the Qt one 
is GPL'd.

-- 
Aaron J. Seigo
Undulate Your Wantonness
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060903/4fdef3f1/attachment.sig>