Some remarks on kdebase revision 595286
bartoschek at gmx.de
Sat Oct 14 00:09:27 BST 2006
- kdebase/konqueror/konq_tabs.h:87 (similar)
int and QWidget * have the same name. Some compilers do not like this.
If tlitem is NULL as indicated by earlier checks, this line crashes.
A nice combo of & and &&.
Line 808 indicates that completionbox could be NULL here.
The return value of QIODevice::putChar is a bool. How can this be < 0?
Lines 56 and 61 are inconsistent in their && and & usage.
Maybe not possible: If sound.size() == 0 and start = stop -1 then
log2size is 65535 here and outside of the allowed shift range.
x_mod and keysym are never assigned. But they are used here.
Line 272/273 suggests that parent2_P could be NULL here.
If the while loop in line 1188 is never entered acList, then acList is
Is this memory also freed?
Line 195 indicates that ctrl.path could be NULL here. memcmp does not like
abs looses precision here. std::abs() or labs() should be better.
Line 511 indicates that list can be NULL. If control reaches this line it
Maybe an assert(false) for the default case. Otherwise line 456 has an out of
Maybe _embedFrame should also be set to NULL as the other pointers in the
m_usbDeviceHandle is a Pointer and cannot be < than 0. I expect "== 0" here.
== binds more than &. Do you really mean
currentRotation() & (ReflectMask == ReflectX) ?
Line 237 allocates some memory and line 238 overwrites the pointer with 0?
And the NULL pointer is then used in sprintf?
What happens with fp after the fopen?
== binds more than ^. Maybe some parentheses here?
buf is used to initialize itself?
More information about the kde-core-devel