[PATCH] kdm: No frame around widgets

Oswald Buddenhagen ossi at kde.org
Wed May 17 18:05:04 BST 2006


On Wed, May 17, 2006 at 06:48:36PM +0200, Aur?lien G?teau wrote:
> Oswald Buddenhagen wrote:
> > i can't say i like the idea of removing the frame. without it lineedits
> > look so flat, just like random rectangles without function. some/all
> > themes work against it, but they make a simple rectangle instead of a 3d
> > effect around it.
> 
> That's true, but this way themes get all control on the borders.
> 
yeah. that's the difference between theory and practice. :)
coolo, what's your opinion?

> > to the patch itself (in case i'm overruled ;):
> > - no superfluous braces in kdm, please
> > - why dynamic_cast instead of q*cast?
> 
> Updated patches attached.
>
looks good.

> Just curious, what is the difference between dynamic_cast and qt_cast?
> 
it's way faster and does not need rtti. and it's the qt way of doing
things. :)

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.




More information about the kde-core-devel mailing list