change bool to enum : KUrl

Olivier Goffart ogoffart at kde.org
Tue May 2 06:03:05 BST 2006


Le Mardi 2 Mai 2006 01:25, Thiago Macieira a écrit :
> Olivier Goffart wrote:
> >So i have done KUrl changes.
> >(path kurl.diff attached)
>
> Two notes:
> 1) there's no need to leave the options as -1, 0 and 1. Let the compiler
> choose the values if you're not creating flags.

It was for keeping compatibility with kde3.
But since it will anyway have a compile error, I'll change that.


> 2) Don't set the default value to 0. Set to a named value.

Why ?  (for my information)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060502/0a2f6ad7/attachment.sig>


More information about the kde-core-devel mailing list