change bool to enum : KUrl

Thiago Macieira thiago at
Tue May 2 00:25:39 BST 2006

Olivier Goffart wrote:
>So i have done KUrl changes.
>(path kurl.diff attached)

Two notes:
1) there's no need to leave the options as -1, 0 and 1. Let the compiler 
choose the values if you're not creating flags.

2) Don't set the default value to 0. Set to a named value.

Thiago Macieira  -  thiago (AT) - thiago (AT)
  thiago.macieira (AT)     Trolltech AS
    GPG: 0x6EF45358                   |  Sandakerveien 116,
    E067 918B B660 DBD1 105C          |  NO-0402
    966C 33F5 F005 6EF4 5358          |  Oslo, Norway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <>

More information about the kde-core-devel mailing list