ksyntaxhighlighter (Re: KDE/kdelibs)

[Laurent Montel]

On Wednesday 18 January 2006 17:13, David Faure wrote:
> On Wednesday 18 January 2006 17:08, Laurent Montel wrote:
> > On Wednesday 18 January 2006 16:58, David Faure wrote:
> > > On Wednesday 18 January 2006 16:33, Maks Orlovich wrote:
> > > > On Wednesday 18 January 2006 10:24, David Faure wrote:
> > > > > > BTW, wouldn't it make sense to call it
> > > > > > KEMailQuotingSyntaxHighlighter or something like that?
> > > > > >
> > > > > > KSyntaxHighlighter is a very generic name for a class that only
> > > > > > highlights quoted emails :)
> > > > >
> > > > > Indeed! And why is it in kdelibs? Seems Scott moved it there to
> > > > > make the
> > > >
> > > > class KDEUI_EXPORT KSpellingHighlighter : public KSyntaxHighlighter
> > >
> > > OK. The confusing part is that KSyntaxHighlighter::highlightBlock is
> > > email specific, this is the part that should be moved out. All we want
> > > in kdelibs is "syntax highlighting using spellchecking". So:
> > > 1) KSyntaxHighlighter should be removed (the quoting code should move
> > > to kdepim)
> >
> > Ok create a specific class into kdepim
>
> Yes, it should derive from KSpellingHighlighter and do the mail stuff on
> top of the spelling stuff instead of the other way round. I think that's
> just a matter of calling the parent class only for non-quoted lines.

Yes I think it's the good way.

> > > 2) KSpellingHighlighter should be removed too, since it doesn't use
> > > kspell2, and in kspell2 there is already a syntax highligher!
> >
> > it's right, but don't use for the moment QTextEdit => need to port it
> > too. kde3support/kspell2 ? (for compatibility ? or any program use it ?
> > (kword/kpresenter use it but I don't know if other program use it)
>
> Yes KSpell2::Highlighter needs to be ported to QTextEdit.
> You mean moving the current (q3syntaxhighlighter) version of it to
> kde3support?

no just ui/highlighter.{h,cpp} but if you say "any code use it" it's not 
necessary we port it to QTextEdit and not necessary to keep compatibility.
After we port KTextEdit to use kspell2 and there is not problem.

> Can't hurt, even though I don't think any code in SVN uses it 
> (even koffice doesn't use that class).
>
> Thanks!