ksyntaxhighlighter (Re: KDE/kdelibs)

David Faure faure at kde.org
Wed Jan 18 15:58:40 GMT 2006

On Wednesday 18 January 2006 16:33, Maks Orlovich wrote:
> On Wednesday 18 January 2006 10:24, David Faure wrote:
> > > BTW, wouldn't it make sense to call it KEMailQuotingSyntaxHighlighter or
> > > something like that?
> > >
> > > KSyntaxHighlighter is a very generic name for a class that only
> > > highlights quoted emails :)
> >
> > Indeed! And why is it in kdelibs? Seems Scott moved it there to make the
> class KDEUI_EXPORT KSpellingHighlighter : public KSyntaxHighlighter

OK. The confusing part is that KSyntaxHighlighter::highlightBlock is email specific,
this is the part that should be moved out. All we want in kdelibs is "syntax highlighting
using spellchecking". So:
1) KSyntaxHighlighter should be removed (the quoting code should move to kdepim)
2) KSpellingHighlighter should be removed too, since it doesn't use kspell2, and in
kspell2 there is already a syntax highligher!
3) KDictSpellingHighlighter might have more stuff than KSpell2::Highlighter
so it should be ported to KSpell2::DictHighlighter.

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list