[Patch] KDialog / KDialogBase

[Olivier Goffart]

Le Dimanche 1 Janvier 2006 15:29, Benjamin Meyer a écrit :
> Does it makes sense to have that one deprecated constructor when so much
> has changed?

It's just to make things compile in my source tree.


Le Dimanche 1 Janvier 2006 15:40, Benjamin Meyer a écrit :
> A few more thoughts
>
> Could the button mask and guiitems be taken out of the constructor and
> moved into there own functions?  Do they have to be in it?

they have already they own function.
and what is the problem of having them in the constructor ? it make the code 
shorter.

> Probably want to move KDialogQueuePrivate into a kdialog_p.h file

I even would like to remove that class.
It is used only for KMessageBox::queuedMessageBox
but it could use show() instead of exec() and the result will be the same

> setFolderIcon should take a QIcon

ok.

> You want to change the int orientation to use the qt enum (i.e. so you can
> do Qt::Horizontal)

done.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060102/4844b317/attachment.sig>