[PATCH] Add signals support to kconfig_compiler

Michaël Larouche michael.larouche at kdemail.net
Mon Feb 6 14:44:38 GMT 2006


Le Jeudi 2 Février 2006 08:49, Michael Brade a écrit :
> On Tuesday 31 January 2006 16:03, Michaël Larouche wrote:
> > Patch included also fix to reference files(to make tests pass), the new
> > test files, modifications to build system (automake and CMake), addition
> > to the Doxygen files.
>
> I noticed that you touched some files (test?.h.ref mainly) only to change
> the coding style by adding { and } to one-line ifs and an additional
> newline at the end of the file. But you are adding new code like
>
> +void TestSignal::usrWriteConfig()
> +{
> +  if ( mSettingsChanged & signalEmoticonSettingsChanged )
> +    emit emoticonSettingsChanged();
> +
> +  if ( mSettingsChanged & signalStyleChanged )
> +    emit styleChanged(mStylePath, mStyleCSSVariant);
>
> so I would suggest to leave the old files as they are. Other than that it
> looks great to me!

I adapted the output so old files still can pass the test without updating 
them.

Can I commit my changes now ? 
-- 
Michaël Larouche (Shock The Dark Mage)
KDE developer working on Kopete, Kamefu...on dial-up :P
--------------------------------------
Blog: http://mlarouche.blogspot.com/
MSN/Email: michael.larouche at kdemail.net
IRC: irc.freenode.org/DarkShock on #kopete,#solid,#kamefu,#plasma
Jabber: darkshock at myjabber.net





More information about the kde-core-devel mailing list