[PATCH] Add signals support to kconfig_compiler

Michael Brade brade at kde.org
Thu Feb 2 13:49:07 GMT 2006

On Tuesday 31 January 2006 16:03, Michaël Larouche wrote:
> Patch included also fix to reference files(to make tests pass), the new
> test files, modifications to build system (automake and CMake), addition to
> the Doxygen files.
I noticed that you touched some files (test?.h.ref mainly) only to change the 
coding style by adding { and } to one-line ifs and an additional newline at 
the end of the file. But you are adding new code like 

+void TestSignal::usrWriteConfig()
+  if ( mSettingsChanged & signalEmoticonSettingsChanged ) 
+    emit emoticonSettingsChanged();
+  if ( mSettingsChanged & signalStyleChanged ) 
+    emit styleChanged(mStylePath, mStyleCSSVariant);

so I would suggest to leave the old files as they are. Other than that it 
looks great to me!

Michael Brade;                 KDE Developer, Student of Computer Science
  |-mail: echo brade !#|tr -d "c oh"|s\e\d 's/e/\@/2;s/$/.org/;s/bra/k/2'
  °--web: http://www.kde.org/people/michaelb.html

KDE 4: Beyond Your Expectations
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060202/3e193c97/attachment.sig>

More information about the kde-core-devel mailing list