[PATCH] Folder icons reflect contents

[David Faure]

On Wednesday 09 August 2006 18:48, Leo Savernik wrote:
> Am Dienstag, 8. August 2006 19:05 schrieb Carsten Pfeiffer:
> > On Tue, Aug 08, 2006 at 06:45:38PM +0200, Remi Villatel wrote:
> > > -    if ( !m_fileitem->isDir() || m_fileitem->iconName() != "folder" )
> > > +    if ( !m_fileitem->isDir() || (m_fileitem->iconName()).left(6) !=
> > > "folder" )
> >
> > Just a little performance improvement: can you use .startsWith("folder")
> > instead of .left()? This avoids creating a temporary QString.
> >
> 
> I wonder why KDE still allows implicit ascii casts. Isn't it about time to 
> switch it *off*, once and for all?

QT_NO_ASCII_CAST is doable, why not. But QT_NO_CAST_ASCII is a major pain in the ass,
where every litteral (like in the above case) needs to be wrapped up... Who's going to
fix all the kde code (w/o introducing bugs, preferrably...) once you have switched the casts off?
I'd rather see this happen incrementally (a few parts of the code use this already) and
being done by the respective maintainers, instead of running a broken script over all of kde.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).