[PATCH] Folder icons reflect contents

Leo Savernik l.savernik at aon.at
Wed Aug 9 17:48:50 BST 2006


Am Dienstag, 8. August 2006 19:05 schrieb Carsten Pfeiffer:
> On Tue, Aug 08, 2006 at 06:45:38PM +0200, Remi Villatel wrote:
> > -    if ( !m_fileitem->isDir() || m_fileitem->iconName() != "folder" )
> > +    if ( !m_fileitem->isDir() || (m_fileitem->iconName()).left(6) !=
> > "folder" )
>
> Just a little performance improvement: can you use .startsWith("folder")
> instead of .left()? This avoids creating a temporary QString.
>

I wonder why KDE still allows implicit ascii casts. Isn't it about time to 
switch it *off*, once and for all?

mfg
	Leo




More information about the kde-core-devel mailing list