Hi, I was looking to change KLockFile::LockOptions to a QFlags. I wanted some feedback on changing the names of the options. I want to go from enum LockOptions { LockNoBlock = 1, LockForce=2 }; to enum LockOption { NoBlock=1, Force=2 }; Q_DECLARE_FLAGS(LockOptions, LockOption) which IMO is cleaner, and more type safe.