patch for KService

[Jens Herden]

Hello David,

thanks for your feedback.

> Hmm, this might break existing code/apps - we return "unknown" because
> that's at least something to display, instead of nothing... OK it's
> arguable if it's better to have a default-white-icon instead of nothing,
> but still...
> Hmm, the K menu has entries without icons at all, how is that possible? I'm
> quite sure it uses KService... Ah, I see:
> ../kicker/ui/addapplet_mnu.cpp:55:        if (ai.icon().isEmpty() ||
> ai.icon() == "unknown") ../kicker/ui/panelmenuiteminfo.h:77:            if
> (!m_icon.isEmpty() && m_icon != "unknown")
>
> I think this means we shouldn't change it for KDE-3.x, it would break
> existing apps, so better just fix the docu and check for "unknown" in your
> code.

I agree, so I will only change the docu and fix KBabel instead. 

> For KDE-4.x, however, I agree, that returning QString::null is better.

Could you do this? I am not yet working on KDE 4.

Jens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050914/4ded46c6/attachment.sig>