[Patch] fix compile kdecore with msvc
ralf.habacker at freenet.de
Sat Oct 29 22:06:16 BST 2005
Am Samstag, 29. Oktober 2005 22:26 schrieb Thiago Macieira:
> Christian Ehrlicher wrote:
> >- masked '#warning' - is gnuc-specific
> >- don't export KResolverResults to avoid compiler errors (*)
> Not acceptable. Don't commit this.
Christian, what kind of compiler message do you get ?
> >- don't include ksockssocketdevice in windows to avoid linker errors
> Understandable. I want to fix that later by other means.
> >- indentation fixes (tabulator -> spaces)
are there any astyle rules available ? It would make live much easier :-)
> >- add kde_ioctl because ioctl isn't available in windows
> >- add kde_ioctl (**)
> Ok, makes sense.
> >* there is imho no need to export KResolverResults because nobody
> >derivates a class from KResolverResults. And if you really want to
> >export this class, you have to implement all functions QList<T> defines
> >because otherwise when someone wants to use a function you forgot to
> >implement he will get a linker error.
> Your argument doesn't make sense. Functions that were not overridden will
> be inherited from QList<T>.
More information about the kde-core-devel