[Patch] fix compile kdecore with msvc
thiago at kde.org
Sat Oct 29 21:26:34 BST 2005
Christian Ehrlicher wrote:
>- masked '#warning' - is gnuc-specific
>- don't export KResolverResults to avoid compiler errors (*)
Not acceptable. Don't commit this.
>- don't include ksockssocketdevice in windows to avoid linker errors
Understandable. I want to fix that later by other means.
>- indentation fixes (tabulator -> spaces)
>- add kde_ioctl because ioctl isn't available in windows
>- add kde_ioctl (**)
Ok, makes sense.
>* there is imho no need to export KResolverResults because nobody
>derivates a class from KResolverResults. And if you really want to
>export this class, you have to implement all functions QList<T> defines
>because otherwise when someone wants to use a function you forgot to
>implement he will get a linker error.
Your argument doesn't make sense. Functions that were not overridden will
be inherited from QList<T>.
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
4. And æfter se scieppend ingelogode, he wrát "cenn", ac eala! se
rihtendgesamnung andswarode "cenn: ne wát hú cennan 'eall'. Ástynt."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the kde-core-devel