[Patch] for kdebase/kfind

David Faure faure at kde.org
Mon Nov 21 15:24:11 GMT 2005


On Saturday 19 November 2005 20:32, Christian Ehrlicher wrote:
>        KMimeType::Ptr typ = *it;
> -      typeBox->insertItem(typ->pixmap( KIcon::Small ), typ->comment());
> +#ifdef _MSC_VER
> +         // don't know why, but in those three mimetypes,
> +         // typ->pixmap() crashes...
> +         if ( typ->name() == "KDataTool" ||
> +                  typ->name() == "KPropsDlg/Plugin" ||
> +                  typ->name() == "RenameDlg/Plugin" )
> +                       continue;
> +#endif

Those are non-mimetype servicetypes.
Ah, I see, KMimeType::allMimeTypes() had a bug, it also returned
non-mimetype servicetypes. Fixed (and added unit test).
Please don't commit the hack.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).


More information about the kde-core-devel mailing list