[PATCH] New KFileItem::assign() for Optimizing KDirListerCache

David Faure faure at kde.org
Fri Mar 25 13:58:56 GMT 2005


On Friday 25 March 2005 14:51, Michael Brade wrote:
> Hi,
> 
> attached is a patch with some KFileItem improvements. It makes it possible to 
> assign a new UDSEntry, which is needed in KDirListerCache::slotUpdateResult() 
> to save all those superfluous new/delete calls.
> 
> The patch also reduces the new/delete operations in the already existing 
> assign() method. The comment in the new assign() about the extra data that I 
> copied from the old assign() is wrong, I'll remove it in the final patch.
> 
> Please check that I didn't miss anything.

OK - can we name it something else than assign, though, to remove some possible confusion?
How about load? setData? update?
update() sounds best I guess. This is about updating the data in an existing kfileitem.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list