[PATCH] dpointer and no-inline functions support for kconfig_compiler
bastian at kde.org
Wed Jun 8 13:09:23 BST 2005
On Tuesday 31 May 2005 22:02, Duncan Mac-Vicar P. wrote:
> the attached patch adds kconfig_compiler support for having private members
> in a dpointer, when this mode is used, the generated methods are moved to
> the implementation. To activate this mode, you use the keyword "dpointer"
> instead of "private" in the kcfgc MemberVariables entry.
> The second patch includes a new test. All the previous (strangely, the
> Makefile.am only tests for the firt four tests) test were passed.
> I also include a kunittest based test in the patch that compares the files
> with the reference ones, so in the future the perl script could be removed.
> Not now, until kunittest supports some features I plan add like better
> strings diffs.
> Please review.
The comment above varName refers to itemPath instead of varPath.
Wrt the tests, you should add the new test to
kconfig_compiler/test/Makefile.am so that you can do "make md5check" in
kconfig_compiler/test (feel free to improve that though). I think it's a bit
confusing to have the tests referenced from kconfig_compiler/Makefile.am
Feel free to commit if all tests pass.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the kde-core-devel