[patch] media:/ mount point info

Kévin Ottens ervin at ipsquad.net
Mon Jan 31 16:54:49 GMT 2005

Le Dimanche 30 Janvier 2005 17:56, Martin Koller a écrit :
> Addressing http://bugs.kde.org/show_bug.cgi?id=95646
> I'd like to commit the following patch.
> I'm not sure if the mountPoint shall belong to the group "mediumInfo" or
> "mediumSummary". What do you think ?

It should go into the mediumInfo group, I keep mediumSummary for things 
calculated (mostly statistics on free space, etc...).

In order to commit it and address bug 95646 (fully), you should slightly 
modify it :
1) Add the device node information
2) Be careful when you fill the information, sometimes mount point or device 
node are not available, in this case you should not display the information 
since it's an empty string.

In the bug report it's asked to display the volume type too (reiserfs, or 
such), it's in my opinion a bad idea since media:/ already provide a type and 
giving a finer information (reiserfs for example) would lead to something 
less portable and clean.

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

More information about the kde-core-devel mailing list