[PATCH] KCrash::setEmergencySaveFunction

[Waldo Bastian]

On Thursday 13 January 2005 08:25, Aaron J. Seigo wrote:
> hi...
>
> i've improved kicker's crash recovery[1] but it seems to have uncovered a
> bug in KCrash::setEmergencySaveFunction. there's a comment in there that
> says:
>
>   /*
>    * We need at least the default crash handler for
>    * emergencySaveFunction to be called
>    */
>
> which is true: without the crashHandler, the emergencySaveFunction won't
> get called. however, while it sets _crashHandler, it never hooks it up to
> the system signals that make it actually work (e.g. SIGSEGV) and as such
> setting the emergencySaveFunction when you don't have a crash handler
> doesn't work. the following one liner fixes this handily.
>
> are there any possible bad sideeffects or can this go in?

Looks good to me.

Cheers,
Waldo
-- 
bastian at kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian at suse.com  |   http://www.novell.com/products/desktop/eval.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050117/676c6b26/attachment.sig>