Patch for KMainWindow

[David Faure]

On Sunday 27 February 2005 18:49, Andras Mantia wrote:
> On Sunday 27 February 2005 01:42, Ian Reinhart Geiser wrote:
> > Greetings,
> >         The current  KMainWindow::setupGUI( ... ) method won't allow
> > you do add more GUI actions after you call it because it calls
> > createGUI with the conserve menu flag set.  Is this patch possible to
> > be used in KDE?  It seems to not break things, but it will make
> > KMainWindow extendable again.

Yes setupGUI has to be useable by apps with ActionLists and KParts IMHO,
so it should not assume "simple case, conserve memory". i.e. please apply.

> IIRC Simon said t hat the usage of conserve-memory is quite evil, 
> especially when you use embedded KParts... I know, I had a 
> hard-to-track down bug in Quanta due to it.

Hmm you can't even use KParts if you have conserve-memory set, AFAIK,
since then gui merging can't happen if the DOM tree was discarded.
At least you can't switch between parts.

Simon talked about removing that flag completely for KDE4. IMHO it would
still be nice to save the memory in really simple apps (no parts, no plugins
and no actionlists). But maybe when using anything that needs the DOM tree,
and the DOM tree was discarded, we could simply print a runtime warning?
This would already help the developer a lot, to know he has to unset "conserve
memory".

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).