[PATCH] Improved Alsa configure-time detection

Thiago Macieira thiago at kde.org
Wed Dec 28 00:05:18 GMT 2005


Christian Esken wrote:
>Ah, 	I understand.
>
>As I don't understand much of KDE's build system I am forwarding to
>kde-core-devel - the experirenced people are there.
>
>Can somebody check the attached patches?

Hello Christian,

The patch is ok (in the sense that it doesn't break anything), but it's 
redundant.

The setting of CPPFLAGS and LDFLAGS is exactly why we have 
KDE_CHECK_{LIB,HEADER}. 

So only one of the two changes is necessary. I'd recommend using the 
KDE_CHECK_* versions, unless you're nesting the tests one inside the 
other.
-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

2. Tó cennan his weorc gearu, ymbe se circolwyrde, wearð se cægbord and se 
leohtspeccabord, and þa mýs cómon lator. On þone dæg, he hine reste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20051227/44a28104/attachment.sig>


More information about the kde-core-devel mailing list