[Patch] two patches to compile kdelibs/khtml on windows
Lubos Lunak
l.lunak at suse.cz
Mon Dec 12 13:26:11 GMT 2005
On Sunday 11 December 2005 16:31, Christian Ehrlicher wrote:
> Lubos Lunak schrieb:
> > On Wednesday 07 December 2005 14:55, Christian Ehrlicher wrote:
> >>>On Tuesday 06 December 2005 06:56, Christian Ehrlicher wrote:
> >>>>Here the fixwinh.h and a patch to include it in the three headers where
> >>>>I get compile errors. It should not affect compilation on linux.
> >>>
> >>> So it really needs to be used in the headers?
> >>
> >>What else should I do? The headers redefine those values and I can't
> >>include fixwinh.h everywhere the headers are included. And if they are
> >>public headers nobody knows that they have to include fixwinh.h first...
> >
> > You got the rule backwards. You have to include fixwinh.h after you
> > include the windows.h header (which should be only a handful of .cpp
> > anyway), that's why the file is called so. You fix what breaks things,
> > not where it breaks.
>
> The problem is that, for example, simply including <sys/time.h> includes
> a windows-header which could cause those problems.
> We need this because only winsock2.h defines timeval... :(
>
> I've attached a new patch which works fine for me, but don't know if
> this is what you want.
Well, if it really can't be done otherwise, then it really can't be done
otherwise *shrug*.
--
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o. e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27 tel: +420 2 9654 2373
190 00 Praha 9 fax: +420 2 9654 2374
Czech Republic http://www.suse.cz/
More information about the kde-core-devel
mailing list