[Patch] two patches to compile kdelibs/khtml on windows

Christian Ehrlicher Ch.Ehrlicher at gmx.de
Sun Dec 11 15:31:19 GMT 2005

Lubos Lunak schrieb:

> On Wednesday 07 December 2005 14:55, Christian Ehrlicher wrote:
>>>On Tuesday 06 December 2005 06:56, Christian Ehrlicher wrote:
>>>>Here the fixwinh.h and a patch to include it in the three headers where
>>>>I get compile errors. It should not affect compilation on linux.
>>> So it really needs to be used in the headers?
>>What else should I do? The headers redefine those values and I can't
>>include fixwinh.h everywhere the headers are included. And if they are
>>public headers nobody knows that they have to include fixwinh.h first...
>  You got the rule backwards. You have to include fixwinh.h after you include 
> the windows.h header (which should be only a handful of .cpp anyway), that's 
> why the file is called so. You fix what breaks things, not where it breaks.

The problem is that, for example, simply including <sys/time.h> includes
a windows-header which could cause those problems.
We need this because only winsock2.h defines timeval... :(

I've attached a new patch which works fine for me, but don't know if
this is what you want.


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fixwinh.h
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20051211/7cb6402b/attachment.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: khtml_fixwinh.patch
Type: text/x-diff
Size: 3513 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20051211/7cb6402b/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20051211/7cb6402b/attachment.sig>

More information about the kde-core-devel mailing list