KSycocaFactory question

Thomas Braxton brax108 at cox.net
Thu Dec 8 06:26:53 GMT 2005


On Wednesday 07 December 2005 23:41, Waldo Bastian wrote:
> On Tuesday 06 December 2005 23:02, Thomas Braxton wrote:
> > In kdecore/ksycocafactory.cpp:181 we have:
> >
> >    qint32 *offsetList = new qint32[entryCount];
> >    for(int i = 0; i < entryCount; i++)
> >    {
> >       stream >> offsetList[i];
> >    }
> >
> >    for(int i = 0; i < entryCount; i++)
> >    {
> >       KSycocaEntry *newEntry = createEntry(offsetList[i]);
> >       if (newEntry)
> >       {
> >          list.append( KSycocaEntry::Ptr( newEntry ) );
> >       }
> >    }
> >    delete [] offsetList;
> >
> > couldn't this be changed to:
>
> No, createEntry modifies the stream position.
>
> Cheers,
> Waldo
Ok, then maybe we should document this so someone else doesn't try to fix this 
again. What's the easiest way to revert this?




More information about the kde-core-devel mailing list