KSycocaFactory question

Waldo Bastian bastian at kde.org
Thu Dec 8 05:41:33 GMT 2005


On Tuesday 06 December 2005 23:02, Thomas Braxton wrote:
> In kdecore/ksycocafactory.cpp:181 we have:
>
>    qint32 *offsetList = new qint32[entryCount];
>    for(int i = 0; i < entryCount; i++)
>    {
>       stream >> offsetList[i];
>    }
>
>    for(int i = 0; i < entryCount; i++)
>    {
>       KSycocaEntry *newEntry = createEntry(offsetList[i]);
>       if (newEntry)
>       {
>          list.append( KSycocaEntry::Ptr( newEntry ) );
>       }
>    }
>    delete [] offsetList;
>
> couldn't this be changed to:

No, createEntry modifies the stream position.

Cheers,
Waldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20051207/beb71c0c/attachment.sig>


More information about the kde-core-devel mailing list