Thiago Macieira thiago at
Wed Dec 7 19:02:02 GMT 2005

Nicolas Goutte wrote:
>Probably a too huge diff, crashing the post-commit hook.

That was true of the Qt update commit, but I doubt Michael's kio fix 
crashed the hook with too huge a diff. He touched two files only.

I have two outstanding issues to fix in the hook:
1) reduce the memory usage. It's loading the entire diff 3 times into 
memory right now [O(n)], but in theory I can reduce it to a fixed size, 
around 30k [O(1)]. Memory usage will still be O(n) to the number of 
files, though

2) move the calculation of the base path to after the diff parsing, so as 
to "rehabilitate" the svk commits.

The third issue (the improper parsing of properties) will require a full 
rewrite of the hook to one using the SVN API instead of running svnlook. 
As you can probably see, I'm not too keen on doing that. (especially 
since that would be in Python, a language I'm not too familiar with)

>(A volunteer is still needed to fix or at least an idea how to convert
> the license check. All this is in
> trunk/KDE/kde-common/sbn/hooks/ for documentation, look
> at Subversions' book in the SVN documentqation.)

What conversion are you talking about?

  Thiago Macieira  -  thiago (AT) - thiago (AT)
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

2. Tó cennan his weorc gearu, ymbe se circolwyrde, wearð se cægbord and se 
leohtspeccabord, and þa mýs cómon lator. On þone dæg, he hine reste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <>

More information about the kde-core-devel mailing list