[PATCH] a little optimization of KJS GarbageCollector

Luciano Montanaro mikelima at cirulla.net
Fri Dec 2 10:44:48 GMT 2005

On Thursday 01 December 2005 22:01, Alexander Neundorf wrote:
> On Thursday 01 December 2005 16:24, Dirk Mueller wrote:
> ...
> > Note that I don't object to the patch getting included at all (except
> > that it makes us differ from safari tree for no good reason).
> Staying in sync with the safari tree sounds like a good reason not to
> include the patch. Even small differences make it harder to keep an
> overview over the differences. And I don't think this patch improves the
> performance, at least with optimization turned on ;-)

Did you check the differences between the JavascriptCore collector.cpp and 
our own? The diff is 781 lines long, while the file itself is 321 lines 
long. Basically, there is not much to compare anyway. Either we switch to 
JavascriptCore collector (or code base...), or we stay with our own.

But, I agree that as an optimisation, it's not worth doing it.

To ease merging with JSCore, a relatively easy start could be to switch the 
variable types to those used there - for example using size_t and uint32_t
where it makes sense.

> Alex

Luciano Montanaro //
              \\ //
               \x/ www.cirulla.net

More information about the kde-core-devel mailing list