[PATCH] Fix KSpell2 + KWord spellcheck problem

Mashrab Kuvatov kmashrab at sat.physik.uni-bremen.de
Mon Apr 25 15:18:17 BST 2005


Hi all,

let me start with KWord first. At the moment, spellchecking with KWord-CVS
works only once. The reason is after spellchecking is finished KWord does not
delete the broker. The attached patch fixes it, but KWord crashes on
"Finished" button in spellchecker dialog. Read on.

Now, KSpell2. Pressing "Finished" button in KSpell2 dialog it emits stop and
done signals. With the current implementation of spellchecking in KWord (plus
attached patch) and KPresenter these apps after catching stop signal delete
the broker. So, emitting done( d->checker->filter()->buffer() ) crashes the
app. The attached patch fixes this too.

Zack, David what do you think? Can we emit only stop signal?

While we are at it, IMHO "Finish" is better than "Finished". Is it just my
taste?

Cheers,
Mashrab. 

-- 
Mashrab Kuvatov
Ph.D student
University of Bremen, IUP
Home-page: www.sat.uni-bremen.de/members/mashrab
PGP key: www.uni-bremen.de/~kmashrab/kmashrab.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dialog.cpp.patch
Type: text/x-diff
Size: 769 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050425/5efa28ca/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwview.cc.patch
Type: text/x-diff
Size: 546 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050425/5efa28ca/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050425/5efa28ca/attachment.sig>


More information about the kde-core-devel mailing list