bug #86756: klistview::selectedItems() returns hidden items

Aaron J. Seigo aseigo at kde.org
Wed Sep 15 02:35:57 BST 2004


On Tuesday 14 September 2004 05:57, Jason Keirstead wrote:
> So really, in what situation would this API be usefull at al? To me it
> looks like a simple oversight.

if the use case is a treeview that the user purposefully select items from and 
then performs some explicit action on them, you may be exactly right.

i'd be surprised if this was the only use case. especially now that we have 
dynamic filtering of lists in use in places such as kmail, juk and elsewhere. 
the patch completely denies the ability to get hidden items which are 
selected back.

a selectedItems(bool includeHiddenItems = true) method would allow both 
"safer" selections in what may well be the common case without crippling the 
API programatically.

there's a difference between saying "This is how it's commonly used, let's 
make it easy, and even the default, way." and saying "You can not use it this 
way, ever."

-- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43




More information about the kde-core-devel mailing list